Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: GetBulk method for new CouchDB storage implementation #49

Conversation

DRK3
Copy link
Contributor

@DRK3 DRK3 commented Jan 14, 2021

  • Also includes a minor refactor for the getQueryOptions function that was added in my previous commit.

Signed-off-by: Derek Trider [email protected]

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #49 (91dd4c2) into main (ab74010) will increase coverage by 0.10%.
The diff coverage is 88.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   83.63%   83.74%   +0.10%     
==========================================
  Files           8        8              
  Lines        1088     1132      +44     
==========================================
+ Hits          910      948      +38     
- Misses         98      101       +3     
- Partials       80       83       +3     
Impacted Files Coverage Δ
component/newstorage/couchdb/store.go 89.58% <88.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab74010...91dd4c2. Read the comment docs.

- Also includes a minor refactor for the getQueryOptions function that was added in my previous commit.

Signed-off-by: Derek Trider <[email protected]>
bulkGetReferences[i].ID = key
}

rows, err := s.db.BulkGet(context.Background(), bulkGetReferences)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder that contexts need to be passed-in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a followup issue earlier for it: #48

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal is to get the storage implementations done first so that I can update the aries-framework-go functionality to use the new storage interface. Then I'll go and make those improvements that can be done easily afterwards.

@DRK3 DRK3 requested a review from troyronda January 15, 2021 21:04
@troyronda troyronda merged commit a85ff47 into hyperledger-archives:main Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants